[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: A better UI than perform-replace

From: Dmitry Gutov
Subject: Re: A better UI than perform-replace
Date: Thu, 19 Nov 2015 03:16:35 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:42.0) Gecko/20100101 Thunderbird/42.0

On 11/19/2015 02:57 AM, Juri Linkov wrote:

I think we need to keep both the current multi-file query-replace and
multi-occur, and extend the latter with query-replace capabilities,
(thus a better mode name would be 'occur-query-replace-mode') because
the current multi-file query-replace is already used in several places
such as tags-query-replace.  Then for xref you could take any of them.

Yes, we'll need a separate occur-??? query-replace function that takes a set of files as an argument.

It would be cool if both query-replace functions had the same calling convention, and we could choose the user-preferred one based on a global variable.

PS: I noticed a FIXME in xref--query-replace-1, and I wonder why can't you
use `multi-query-replace-map' the same way as it's used in tags-query-replace?

Last time I tried, it wasn't a drop-in replacement: with `multi-query-replace-map', `perform-replace' really expects to be called once per buffer, and it would've been really inconvenient in the initial implementation. Less so with the current one, though.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]