[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Dynamic loading progress

From: Paul Eggert
Subject: Re: Dynamic loading progress
Date: Fri, 20 Nov 2015 12:39:01 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0

Eli Zaretskii wrote:
I suspect the push_handlers changes in aa7dac8.

No, it was the reindenting change! I got confused by the do-while indenting in a complicated macro. Fixed in commit 95f69f2c5999be4b9444861b6d4ae1bd3ab87f83. I also noticed some int/ptrdiff_t issues in mod-test.c, and fixed them in commit 39d13206f3b37261bf4a2ebadfc1103414f4fd3e. Plus, I assume emacs_module_init is part of the module API? If so, it should be declared in emacs-module.h, which I did in commit d0e07e0e2239771fd21b9525ea421cf7ba1cc97c.

I didn't notice all these problems because I wasn't running that test. I was just doing 'make check'. Philipp, shouldn't mod-test.c part of 'make check', when Emacs is configured --with-modules? Also, shouldn't the mod-test.c Makefile use the same GCC warning flags etc. that everyone else does? That would help catch these bugs better.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]