[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: setq's with missing final arguments.

From: David Kastrup
Subject: Re: setq's with missing final arguments.
Date: Sun, 22 Nov 2015 13:31:53 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux)

Alan Mackenzie <address@hidden> writes:

> Hello, Emacs.
> Consider this file:
> ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
> (defvar foo t)
> (defvar bar t)
> (defun bad-setq ()
>   "Doc string"
>   (setq foo 5
>       bar))
> ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
> In the setq, there is a missing argument after "bar".  At the moment,
> the byte compiler just generates code to assign nil to bar, without
> giving any warning.  IMAO, this is Very Bad.
> I propose to insert code into the byte compiler to detect and warn of
> this scenario:


> Any objections?

Yes.  This is not a case for a warning.  It's an error.  It does not
match the documented definition of setq.

David Kastrup

reply via email to

[Prev in Thread] Current Thread [Next in Thread]