[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [ELPA] New Package: resize-mode

From: daniel sutton
Subject: Re: [ELPA] New Package: resize-mode
Date: Sun, 22 Nov 2015 09:52:31 -0600

Why is it called `background-face' if it only sets the foreground?
I was following the style of ace-window as I am new to this. I will update that.

Really small nitpick, but this would read better as a cond. (And that
> progn is redundant).
Totally agree

Is there a reason why this is done like this? Why not just set this
> value inside the defvar?
I was adding things to this and defvar only sets it if it is unbound. I figured since this is so easy to read and simple, people might add their own and eval the buffer. This makes it trivial to add more options.

besides, this package is not a mode.
Totally agree. My thinking drastically changed as I went.

Thanks so much for taking the time to look at my code. 

In the elpa wiki it mentioned that if you don't have push rights your code will be added by someone else after two days. I have an account on Savannah but I'm I never saw if this includes push rights to elpa, although I would assume not. Does anyone know what further steps I will need to take?

On Sun, Nov 22, 2015 at 9:32 AM, Eli Zaretskii <address@hidden> wrote:
> From: Yuri Khan <address@hidden>
> Date: Sun, 22 Nov 2015 10:14:05 +0600
> Cc: emacs-devel <address@hidden>
> This might benefit from also binding [Shift+]arrow keys as well.

Which IMO should allow pixel-granular resizing.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]