[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] * lisp/ibuffer.el: Add ability to (un-)mark or delete buffer

From: John Wiegley
Subject: Re: [PATCH] * lisp/ibuffer.el: Add ability to (un-)mark or delete buffers in the region.
Date: Mon, 14 Dec 2015 10:29:29 -0800
User-agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/24.5 (darwin)

>>>>> Eli Zaretskii <address@hidden> writes:

>> This is what this patch is about. It doesn't change previous behaviors, and
>> just adds the ability to select with the region. For the sake of simplicity,
>> I didn't modify current menu labels, the mode's help, nor renamed the
>> impacted functions.

> Could someone who uses ibuffer.el please look into this patch and provide
> comments?

Foudil, why does this patch rely on the use of the region to select a group of
buffers, rather than the existing functionality of using 'm' to mark buffer(s)
for subsequent action? This is a pattern used by many other modes, such as

In my brief testing, dired does not allow aggregate actions based on regions
either. Therefore, since ibuffer advertises itself as "a dired for buffers" --
and likewise, proced for processes -- the method for dealing with aggregate
targets should be kept consistent.

Thus, I'm inclined to reject this patch in favor of the existing "marking"

John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]