[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Should we have a commit size guideline?

From: John Wiegley
Subject: Re: Should we have a commit size guideline?
Date: Tue, 15 Dec 2015 09:56:56 -0800
User-agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/24.5 (darwin)

>>>>> Eli Zaretskii <address@hidden> writes:

> I generally prefer to see the commits in one go, rather than split. It makes
> it easier for me to review it.

The best of both worlds should be: A commit series from a feature branch,
merged into the target branch. This allows using "commit^..commit" to view all
the changes in one go against the target branch, while just "commit" will show
the series and it evolved on the feature branch.

Rebasing the feature branch also makes this nicer to read, as it omits
possibly frequent back-merges from the target into the feature branch as it
was being worked on.

John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2

reply via email to

[Prev in Thread] Current Thread [Next in Thread]