[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Should we have a commit size guideline?

From: Paul Eggert
Subject: Re: Should we have a commit size guideline?
Date: Tue, 15 Dec 2015 17:00:07 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0

Dmitry Gutov wrote:
Emacs doesn't change tabs to spaces if the indentation level of the line
hasn't changed.

I observe problems in this area when changing code (which changes indentation) and then changing it back (i.e., not undo, but make a further change that undoes most or all of the original change). In this case Emacs changes tabs to spaces, assuming the .dir-locals.el settings already mentioned.

we've always considered tabs-to-spaces changes near some actual
changed code to be okay.

Yes, of course. Here, though, a two-line changed ballooned into a 23-line change. The first 2 lines of the ballooned change were real, and the other 21 lines were tabs-to-spaces only.

It is a bit of an annoyance, that's all. Obviously there are workarounds. It's not something I'd bother writing about, but I'm sympathetic to those bothered enough to write.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]