[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] scratch/follow e8937ed: Replace GROUP argument in six

From: Alan Mackenzie
Subject: Re: [Emacs-diffs] scratch/follow e8937ed: Replace GROUP argument in six window primitives by new functions.
Date: Fri, 18 Dec 2015 10:57:49 +0000
User-agent: Mutt/1.5.23 (2014-03-12)

Hello, John and Juri.

On Thu, Dec 17, 2015 at 04:43:12PM -0800, John Wiegley wrote:
> >>>>> Juri Linkov <address@hidden> writes:

> >> I think it would have to be `recenter-window-group', but is
> >> `recenter-group' really that ambiguous? People have no problem with
> >> `recenter', which, if anything, is even more ambiguous.

> > I don't know why `recenter' is not `recenter-window' like other existing
> > functions e.g. `reposition-window'. Maybe for historical reasons. But
> > `recenter-group' will add more ambiguity: recenter what? what group?

> I prefer recenter-window-group.

OK, I'm outvoted.  :-)  I've changed the name in the source and
documentation, including changing `recenter-group-function' to

The end of the week is fast approaching.  I think the time is now ripe
for merging this change into the emacs-25 branch.  Any more objections?

> And maybe we should have `recenter-window' as an alias for `recenter',
> just for consistency.

Or, maybe not.  `recenter' is surely a very old function indeed, and
will have grandfather rights to its name.  I think introducing the alias
(for which there seems no need) would foster confusion.

Also, there is `recenter-top-bottom', which for consistency, would also
want the alias `recenter-window-top-bottom'.

Assuming we have no intention of phasing out the existing names, I don't
think we should introduce the aliases.

> -- 
> John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
> http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2

Alan Mackenzie (Nuremberg, Germany).

reply via email to

[Prev in Thread] Current Thread [Next in Thread]