[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Dynamic modules: MODULE_HANDLE_SIGNALS etc.

From: Eli Zaretskii
Subject: Re: Dynamic modules: MODULE_HANDLE_SIGNALS etc.
Date: Sun, 20 Dec 2015 21:00:06 +0200

> From: Philipp Stephani <address@hidden>
> Date: Sun, 20 Dec 2015 18:27:19 +0000
> Cc: address@hidden, address@hidden, address@hidden, 
>       address@hidden, address@hidden
>     and did you make sure
>     that signaling an error from a module still reports the same
>     information and backtrace as before the change?
> No, but I wouldn't know how the patch should change this. It only changes an
> implementation detail in the error reporting code of the module implementation
> itself.

I provided one such test here:


and the resulting backtrace here:


> If we wanted to check the backtrace, I think we should rather add a unit test
> for it. 

That would be good, thanks.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]