[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Add FIXME comment re stack overflow and modules

From: Eli Zaretskii
Subject: Re: Add FIXME comment re stack overflow and modules
Date: Mon, 21 Dec 2015 20:10:19 +0200

> Cc: address@hidden
> From: Paul Eggert <address@hidden>
> Date: Mon, 21 Dec 2015 09:40:26 -0800
> Eli Zaretskii wrote:
> > By "does not work" here, did you mean that using MODULE_FUNCTION_BEGIN
> > will fail to catch the jump out of the SIGSEGV handler?
> I did not analyze emacs-module.h and emacs-module.c carefully enough to find 
> the 
> exact problem areas.

IMO, it hardly makes sense to have comments that add confusion rather
than explain clearly the issues.  I clarified that comment a bit.

> For example, the module code contains comments like "It is very
> important that pushing the handler doesn't itself raise a signal"
> that suggest that the corresponding code is incompatible with stack
> overflow checking.

I think it refers to Fsignal, not to signals caught by sigaction

reply via email to

[Prev in Thread] Current Thread [Next in Thread]