[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] emacs-25 1f680db: Fix compilation next-error in buffer

From: Stefan Monnier
Subject: Re: [Emacs-diffs] emacs-25 1f680db: Fix compilation next-error in buffers with selective-display
Date: Sun, 03 Jan 2016 11:02:17 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux)

> +(defun compilation-beginning-of-line (&optional n)
> +  "Like `beginning-of-line', but accounts for lines hidden by 
> `selective-display'."
> +  (if (or (not (eq selective-display t))
> +          (null n)
> +          (= n 1))
> +      (beginning-of-line n)
> +    (re-search-forward "[\n\r]" nil 'end (1- n))
> +    (if (< n 0)
> +        (beginning-of-line))))

All this extra cruft to support an obsolete feature we should eliminate
is the reason why I didn't fix it earlier.
There are reams of other places where selective-display can cause errors
and where similar "simple" fixes could be added.

The problem is/was not in compile.el but in selective-display (which
should just die its deserved death).


reply via email to

[Prev in Thread] Current Thread [Next in Thread]