[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] emacs-25 f5c762c: Additional changes for "make check-e

From: Michael Albinus
Subject: Re: [Emacs-diffs] emacs-25 f5c762c: Additional changes for "make check-expensive"
Date: Tue, 12 Jan 2016 20:03:42 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux)

address@hidden (Phillip Lord) writes:

> Michael

Hi Philip,

> I think that there is a problem with this commit, in that the default
> selector is only used for "make check". By default "make check-maybe"
> runs all tests (including the expensive ones). So, you have to do
> make check-maybe SELECTOR="(quote (not (tag :expensive-test)))"
> I think it makes more sense for check-maybe to skip expensive tests,
> unless told otherwise, as "make check-maybe" is a good candidate for use
> pre-commit.

I see. Before touching the Makefile, we shall agree how all the targets
shall behave. I would say, that "check" and "check-maybe" shall skip the
expensive tests. "check-expensive", "<foo>", and "<foo>.log" shall run
all tests.

> Phil

Best regards, Michael.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]