Re: [PATCH] Override Windows default Win-* key combinations when using Emacs

[Jussi Lahdenniemi]

On 13.1.2016 17.57, Eli Zaretskii wrote:
> If you can see in GDB where does this come from and show the
> backtrace, that would be great.  Failing that, let's leave Windows 9X
> testing alone for a while (you can always test the fallback code by
> forcefully failing one of the run-time tests for the newer versions)
> and test only on W2K.  We can return to the 9X problem later.

I was able to get a GDB dump of this, after installing MinGW from 2009. 
The backtrace is attached.

> I presume you built on a newer version of Windows and only ran on
> Windows 9X?  I don't think the build procedure supports 9X.

Yes, exactly.

> > Getting back to the original issue: I verified that my code works on
> > Win2000. Unfortunately, I was not able to install NT4 on a VM, so I
> > cannot verify the code on that.
>
> That's OK, W2K is good enough.  Thanks.

I *was* able to get NT4 installed finally as well, in a VM running 
inside a Win7 VM.  However, even the official Emacs 24.5 release binary 
fails to work on NT4.  It dies right at the start due to being unable to 
load its initialization files.

I investigated the problem and found out that it resulted from NT4's 
MultiByteToWideChar function not supporting the MB_ERR_INVALID_CHARS 
flags.  I made the flag conditional on the OS version, after which Emacs 
runs just fine on NT4.  I'm attaching a patch that contains this fix, 
and the conditional use of _resetstkoflw (which is also not supported on 
NT4) as well.

Also, I noticed that addpm.exe fails to load on a out-of-the-box NT4SP6, 
due to its dependency to a Shell32.dll version that ships with IE4. 
After installing IE4, addpm works.  It's worth noting that directly 
installing IE6 on NT4 does NOT make addpm functional, as IE6 does not 
contain the shell update.

My keyboard hooking code works on NT4 as well (although not on console 
mode due to the lack of the GetConsoleWindow function - I'll try to find 
a workaround for this).

--
Jussi Lahdenniemi

emacs-w98-crash.txt
Description: Text document

0001-Windows-98-and-NT4-compatibility-fixes.patch
Description: Text document