[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Windows 9X crash

From: Jussi Lahdenniemi
Subject: Re: Windows 9X crash
Date: Fri, 15 Jan 2016 11:35:20 +0200
User-agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1

On 15.1.2016 10.08, Eli Zaretskii wrote:
Right, this can explain everything.  It probably means that a build
configured --with-wide-int should also be tested there, as it has
different alignment needs.

I'll test that as well, then.

How should we fix this?  I can write and test the fix, but I'd like to
hear your opinion on the preferred mechanism.

What fix did you have in mind?  Over-allocating and recording the
offset in the initial part of the block that we don't pass to the

That was my first idea, yes. Of course, this introduces some memory overhead, especially if there are many small allocations.

A proposal patch is attached. Reallocs needed some additional care, as there are two special cases to handle (source being in dumped memory, and source and destination alignments mismatching).

Jussi Lahdenniemi

Attachment: win98-heap-fix.diff
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]