[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Override Windows default Win-* key combinations when using E

From: Eli Zaretskii
Subject: Re: [PATCH] Override Windows default Win-* key combinations when using Emacs
Date: Sat, 16 Jan 2016 11:58:24 +0200

> Date: Thu, 14 Jan 2016 20:15:56 +0200
> From: Eli Zaretskii <address@hidden>
> Cc: address@hidden
> > I investigated the problem and found out that it resulted from NT4's 
> > MultiByteToWideChar function not supporting the MB_ERR_INVALID_CHARS 
> > flags.  I made the flag conditional on the OS version, after which Emacs 
> > runs just fine on NT4.  I'm attaching a patch that contains this fix, 
> > and the conditional use of _resetstkoflw (which is also not supported on 
> > NT4) as well.
> Thanks, I will push these to the emacs-25 branch soon.

Done now.

Note one gotcha with calling functions that might not be available at
run time: you cannot rely on a static function pointer to be NULL when
Emacs starts.  That's because when Emacs is dumped, the value of the
pointer from the system where Emacs is built is (or could be) recorded
in the dumped binary, and is non-NULL.  So you must explicitly zero it
out every Emacs startup; see the various globals_of_w32* functions
which do this for several such pointers.  I added a line to reset the
resetstkovflw pointer when Emacs starts.

> > Also, I noticed that addpm.exe fails to load on a out-of-the-box NT4SP6, 
> > due to its dependency to a Shell32.dll version that ships with IE4. 
> > After installing IE4, addpm works.  It's worth noting that directly 
> > installing IE6 on NT4 does NOT make addpm functional, as IE6 does not 
> > contain the shell update.
> Thanks, I will mention this in some place, although addpm is
> semi-obsolescent nowadays.

Added an entry in etc/PROBLEMS about this.


P.S. These patches all but exhaust your grace limit of contributed
code we can accept without your assigning copyright, so I hope your
legal paperwork is well under way, and we will be able to accept your
contributions soon.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]