[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Merging the xwidget branch

From: Eli Zaretskii
Subject: Re: Merging the xwidget branch
Date: Tue, 19 Jan 2016 17:53:40 +0200

> From: address@hidden
> Cc: address@hidden
> Date: Mon, 18 Jan 2016 22:52:00 +0100
> How about this? 

Looks good, except...

>       * emacsgtkfixed.c (emacs_fixed_gtk_widget_size_allocate)
>       (emacs_fixed_class_init):
...this.  Something is missing after that colon, right?

>       New files for xwidgets:
>       * xwidget.c, xwidget.h, xwidget.el:

This should just say

        * src/xwidget.c:
        * src/xwidget.h:
        * lisp/xwidget.el: New files.

>     Co-authored-by:  Grégoire Jadi  <address@hidden>

This should be on a separate line by its own.

Otherwise, it's good to go, thanks.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]