[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Fix compilation erorr when --enable-gcc-warnings passed

From: Paul Eggert
Subject: Re: [PATCH] Fix compilation erorr when --enable-gcc-warnings passed
Date: Sat, 23 Jan 2016 01:08:08 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1

Alexander Kuleshov wrote:
And seems that this version of the lookup_rgb_color() is only for these 
platforms, because I see that the src/image.c contains yet another 
implementation of the lookup_rgb_color() for platforms where 

Although there are two lookup_rgb_color implementations, the buggy one is invoked if USE_CAIRO, and this generates garbage on the screen. I have filed a bug report; see:


I installed a patch into emacs-25 to replace the compile-time warning with a run-time crash, if you configure --with-cairo --enable-checking and visit a .png file. This patch should also fix the other warnings you noticed, albeit in different ways sometimes.

Thanks for doing this checking! It found a real bug.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]