[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Fix compilation erorr when --enable-gcc-warnings passed

From: Alexander Kuleshov
Subject: Re: [PATCH] Fix compilation erorr when --enable-gcc-warnings passed
Date: Sat, 23 Jan 2016 17:57:03 +0600
User-agent: Mutt/1.6.0-rc0 ((null))

On 01-23-16, Paul Eggert wrote:
> Although there are two lookup_rgb_color implementations, the buggy one is
> invoked if USE_CAIRO, and this generates garbage on the screen. I have filed
> a bug report; see:
> http://bugs.gnu.org/22442
> I installed a patch into emacs-25 to replace the compile-time warning with a
> run-time crash, if you configure --with-cairo --enable-checking and visit a
> .png file. This patch should also fix the other warnings you noticed, albeit
> in different ways sometimes.
> Thanks for doing this checking! It found a real bug.

I'm long-time emacs user, but just started to dive into its source code. Saw
some problems during compilation and decided to send a patch because these minor
things like compiler warnings sometimes brings useful results.

One question, You sad that you installed a ptach..., but where can I find this
patch? I've looked into http://bugs.gnu.org/22442, but can't find it there.

Thank you

reply via email to

[Prev in Thread] Current Thread [Next in Thread]