[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Update of pcase docs for the elisp manual

From: Eli Zaretskii
Subject: Re: Update of pcase docs for the elisp manual
Date: Fri, 29 Jan 2016 17:37:13 +0200

> From: Andy Moreton <address@hidden>
> Date: Fri, 29 Jan 2016 15:14:17 +0000
> Fair enough. Please consider starting a new paragraph though:
> "The ‘cond’ form lets you choose between alternatives using predicate
> conditions that compare values of expressions against specific values
> known and written in advance.  However, sometimes it is useful to select
> alternatives based on more general conditions that distinguish between
> broad classes of values.
> The ‘pcase’ macro allows you to choose between alternatives based on
> matching the value of an expression against a series of patterns. A
> pattern can be a literal value (for comparisons to literal values you’d
> use ‘cond’), or it can be a more general description of the expected
> structure of the expression’s value."

Fine with me, thanks.  Feel free to commit.

> >> However the doc strings are inconsistent with the manual:
> >>   pcase:  (PATTERN CODE...)
> >>   cond:   (CONDITION BODY...)
> >> 
> >> It would be better to use consistent terms.
> >
> > Blame those who wrote the doc strings ;-)
> I sought improvement, not blame :-)

Feel free to improve the doc strings in that direction, and thanks.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]