[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Is it time to drop ChangeLogs?

From: Dmitry Gutov
Subject: Re: Is it time to drop ChangeLogs?
Date: Mon, 7 Mar 2016 23:19:28 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0

On 03/07/2016 10:46 PM, Nikolaus Rath wrote:

When I submitted my first Emacs patch, I was astonished when I was asked
to re-submit with my commit message essentially duplicated in the

Was your commit message already written in ChangeLog format?

How can it be an increased burden if reviewers have to review just one
thing (the commit message) instead of two (commit message and

Eli was stating something more general, but to get into specifics: often, I only need to read the patch's introduction (high-level description), and its ChangeLog entry, to understand it well enough.

A diff contains the same information, but it's usually longer, could be harder to read, and often you don't see right away which function a given change is being changed, especially if the function is long, and the change is right in the middle of it (though that can be alleviated with language-specific diff options).

And then, I can look through the diff, compare it against the ChangeLog, and see if there are any discrepancies. So the odds of getting some unrelated changes (or missing some related ones) is lower.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]