[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Code reviews

From: Phillip Lord
Subject: Re: Code reviews
Date: Wed, 09 Mar 2016 15:06:47 +0000
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Stefan Monnier <address@hidden> writes:

>>> Maybe we could have a half-way system, where commits are pushed to
>>> a branch that is "not fast-forward-only", and this branch is then
>>> auto-merged to the real (fast-forward-only) master branch after a delay
>>> (one day, maybe?) to give time to fix mess ups before they're cast
>>> in stone.
>> I think that this would require some considerable co-ordination.  If I
>> push a broken commit to devel branch, and then you fix this commit
>> through rebase, my copy of the branch (and everyone elses) is now
>> broken.  I'm pretty sure that this kind of fix up can only happen on a
>> feature branch in a sane way.
> I think you misunderstood me: what I was thinking about in the quoted
> text is a system where you submit a pull request to a review queue (not
> to some kind of shared "proto-master" branch), and those requests are
> automatically accepted after some timeout.

Oh. You mean "where commits are pushed to a branch" as in "some branch"
rather than "all commits are pushed to a specific branch".

So, essentially a PR system with a time out.

That would be quite nice.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]