[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] * etc/themes/wombat-theme.el: Don't set foreground on region

From: Mitchel Humpherys
Subject: Re: [PATCH] * etc/themes/wombat-theme.el: Don't set foreground on region
Date: Mon, 14 Mar 2016 10:22:29 -0700
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux)

On Sun, Feb 28 2016 at 06:53:45 AM, Drew Adams <address@hidden> wrote:
>> > Setting a foreground color on the `region' face is slightly
>> > annoying.
>> > This is subjective, of course, but the consensus among other
>> > themes and around the web is to *not* set a foreground color
>> > on the region face.
>> Any objections to this?  I should have mentioned that the reason
>> it's slightly annoying is because setting a foreground color hides
>> existing syntax highlighting within the region text.
> A particular theme can do anything its authors and users want,
> of course.  But wrt the general question of whether region (aka
> selection) highlighting should override other highlighting, see
> Emacs bug #15899.
> http://debbugs.gnu.org/cgi/bugreport.cgi?bug=15899
> IMO, selection highlighting should, at least by default, visibly
> cover the entire selection.  Otherwise, it is not always clear
> what the region limits are.

Just to be clear, when I said "syntax highlighting" I meant it in the
general sense of colors applied to the *foreground* of code in order to
highlight the syntax of the language.  I believe you're referring to
background highlighting, which shouldn't be affected by this patch.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]