[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: A cleaning-up patch for parse-time.el

From: Marcin Borkowski
Subject: Re: A cleaning-up patch for parse-time.el
Date: Sat, 19 Mar 2016 08:49:49 +0100
User-agent: mu4e 0.9.13; emacs

On 2016-03-19, at 08:41, John Wiegley <address@hidden> wrote:

>>>>>> Marcin Borkowski <address@hidden> writes:
>> in my attempt to enhance Org-mode's date/time parsing, I found out that
>> I'll probably need to submit some modifications to `parse-time-string'.
>> While studying parse-time.el, I encountered some code whose purpose was
>> not obvious at the first glance, so I corrected it.  I attach a patch.
>> Is submitting such a patch a good idea?  (It does not introduce any new
>> features or bugfixes, just cleaning up: adding/expanding docstrings,
>> making one argument name better, adding a newline, and changing `not'
>> into `null'.)  How do I write a commit message for that?  (I went for
>> simplicity/terseness, since the diff speaks for itself.)
> Hi Marcin,
> If you also include tests that show that the behavior is unchanged or merely
> corrected from what we had before, then this sounds like something that would
> be good for emacs-25. Otherwise, I'd suggest it be a patch against master,
> pending review by others.

Hi John,

thanks for prompt response!

I think that the changes in this particular case are so cosmetic that
testing them would be overkill.  (Of course, I meant it to be applied to
master!)  OTOH, I expect to submit more complicated things in the
future, so I'll have to learn how to write tests for Emacs code, too.
Is there any documented policy on that or should I just look at the
tests already there?  (I can't see anything about testing in
admin/notes.)  Do I use ERT for testing?  Where do I put tests?


Marcin Borkowski
Faculty of Mathematics and Computer Science
Adam Mickiewicz University

reply via email to

[Prev in Thread] Current Thread [Next in Thread]