[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master b082371: Change do-not-merge pattern to "do not merge"

From: Paul Eggert
Subject: Re: master b082371: Change do-not-merge pattern to "do not merge"
Date: Tue, 22 Mar 2016 16:50:38 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0

On 03/22/2016 03:28 PM, Glenn Morris wrote:
Should also include "don't merge", "no need to merge",
etc. (Unless you think you can get Emacs developers to follow a
convention, which history suggests is unlikely.)
I added "no need to merge". As "don't merge" is typically a false alarm (of its six occurrences in the emacs-25 log, five are false alarms), I left it out. Let's try to stick with "do not merge" or "no need to merge" in future commit messages of this type.

This pattern needs to
err on the side of false positives rather than false negatives

Unfortunately it's not that simple. As we've seen, applied false positives cause patches to be lost, an error that is unlikely to be caught when others review the merge, and some of these errors lurked in 'master' for over two months. In contrast, applied false negatives cause wrong patches to be added, which is much more likely to be caught right away on review. So although it makes sense for other reasons to err on the side of false negatives, our thumbs shouldn't press too hard on the scale.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]