[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Help understanding the URL code

From: Clément Pit--Claudel
Subject: Re: Help understanding the URL code
Date: Thu, 7 Apr 2016 12:02:56 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0

Hi Lars,

On 04/06/2016 12:34 PM, Lars Magne Ingebrigtsen wrote:
> Your patch looks good

Thanks for the review!

> but perhaps this part could be changed a bit:
> (...)
> It should be possible to not have a User-Agent header at all.  nil as a
> value to `url-user-agent' would be the obvious choice, and `default'
> could be the value to signal using `url-http--user-agent-default-string'.

You're right; it doesn't hurt to have that option locally too, in addition to 
tweaking the privacy level.

Please find an updated patch attached :) (I would also welcome comments about 
the commit message format; should I link to this discussion?)


Attachment: 0001-Take-Emacs-and-package-versions-into-account-in-URL-.patch
Description: Text Data

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]