[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] emacs-25 4d8fd9c 4/4: Handle "empty line" regexp in xr

From: Dmitry Gutov
Subject: Re: [Emacs-diffs] emacs-25 4d8fd9c 4/4: Handle "empty line" regexp in xref searches
Date: Wed, 4 May 2016 02:18:30 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1

Hi John,

On 05/04/2016 02:08 AM, John Wiegley wrote:

branch: emacs-25
commit 4d8fd9cf338cf9b5dfc613657adfeabff2d9c14e
Author: Dmitry Gutov <address@hidden>
Commit: Dmitry Gutov <address@hidden>

    * lisp/progmodes/xref.el (xref--collect-matches-1): Stop after one
    match if re-search-forward doesn't move point (bug#23426).

Was this issue on our blocking list?

Apparently not.

Should it have been?

I believe so, yes. But if Eli thinks otherwise, feel free to revert it.

There was another, considerably less critical, but also less risky change in the same push (6f82d8e). If anything, I expected that one to spark some discussion. It's straight up performance improvement, however.

Again, feel free to revert in on emacs-25. Then I'll avoid making similar changes there.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]