[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Another todo-mode bug fix, ok for emacs-25?

From: Eli Zaretskii
Subject: Re: Another todo-mode bug fix, ok for emacs-25?
Date: Wed, 04 May 2016 18:18:39 +0300

> From: Stephen Berman <address@hidden>
> Date: Wed, 04 May 2016 15:59:11 +0200
> In bug#23447 I show how to reproduce a todo-mode bug I encountered
> involving archived items and provide a fix for it.  The bug does not
> result in data loss or file corruption, but changes the behavior of
> todo-show in a way that can only be repaired by resetting internal
> variables or unloading and reloading todo-mode.el.  The patch has no
> effect outside of todo-mode, and I've tested all uses of the function
> involved within todo-mode and encountered no problems, so is it all
> right for me to commit the fix to emacs-25?

We don't want to release Emacs 25.1 with a buggy todo-mode, so the
fact the change is local helps, but not enough.  Please try to
convince us that the change itself is safe.  For example, is the
affected code called in different use cases than the one you anted to
fix, and if so, did you make sure those other use cases still work OK?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]