[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] master 81204b2: Port xref-tests to master branch

From: Dmitry Gutov
Subject: Re: [Emacs-diffs] master 81204b2: Port xref-tests to master branch
Date: Sat, 7 May 2016 23:26:24 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1

Does anyone have better suggestions than

(defvar xref-tests-data-dir
  (expand-file-name "../../data/xref/"
(file-name-directory (or load-file-name (buffer-file-name)))))


'cd test && make test-file-name' is handy, but it's not a full replacement: when running ERT interactively, you get niceties like being able to drop into the debugger right where a test fails.

On 05/06/2016 08:15 PM, Dmitry Gutov wrote:
Hi Paul,

On 05/06/2016 08:09 PM, Paul Eggert wrote:
 (defvar xref-tests-data-dir
   (expand-file-name "data/xref/"
-                    (file-name-directory (or load-file-name
+                    (getenv "EMACS_TEST_DIRECTORY")))

Is this change necessary?

Up until now I've always been able to just open a test file, M-x
eval-buffer, and run the tests in the current Emacs instance with M-x ert.

This change seems like it will break that workflow.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]