[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Issue in src/xfns.c

From: Christian Lynbech
Subject: Issue in src/xfns.c
Date: Tue, 14 Jun 2016 20:02:45 +0200
User-agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.1.50 (darwin)

I am not entirely sure what the intention was, but I think there is a
small issue in xfns.c in relation to the RANDR13_LIBRARY macro.

It is used in two places, one where it uses #if and another that uses
#ifdef, the latter of which I think should have been a #if. At least it
failed to compile for me on a rather old linux system with a setup I
know onbly a little about. The define that introduces RANDR13_LIBRARY is
a boolean expression so RANDR13_LIBRARY is always defined.

As far as I can see this is still present in the git repository on the
master branch. An attempt of a patch is given below.

Index: xfns.c
--- xfns.c              (revision 7708)
+++ xfns.c           (working copy)
@@ -4286,7 +4286,7 @@
   n_monitors = resources->noutput;
   monitors = xzalloc (n_monitors * sizeof *monitors);
   if (randr13_avail)
     pxid = XRRGetOutputPrimary (dpy, dpyinfo->root_window);

Christian Lynbech       | christian #\@ defun #\. dk
Hit the philistines three times over the head with the Elisp reference manual.
                                        - address@hidden (Michael A. Petonic)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]