[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Is it time to drop ChangeLogs?

From: Alan Mackenzie
Subject: Re: Is it time to drop ChangeLogs?
Date: Thu, 7 Jul 2016 13:57:39 +0000
User-agent: Mutt/1.5.24 (2015-08-30)

Hello, Phillip.

On Thu, Jul 07, 2016 at 02:01:34PM +0100, Phillip Lord wrote:
> Alan Mackenzie <address@hidden> writes:

> > I don't know exactly what is meant by "pull request" and "pull request
> > system".  I don't think they are established terms.

> https://en.wikipedia.org/wiki/Distributed_version_control#Pull_requests

> You send an email saying "here are the changes that I want to
> incorporate".


> > The term seems to imply that instead of a contributor pushing a change
> > from his machine to a central repository, some specially authorised
> > authority would pull the change from the contributor's machine.  This
> > would seem to imply every contributor needing to set up an scp daemon on
> > his local machine, which doesn't feel like a Good Thing.

> On *some* machine, yes. That can be their own server, or a hosted git
> repository, or a branch on the Emacs git repository.

The only one of these usable by me would be the last one.  I can foresee
this branch would be open to anybody to commit anything, and could
quickly fill up with questionable changes.  Anybody using this method
would need to maintain their own copy of this "pull" branch.  This could
lead to quite a few logistical problems, could it not?

Also, the email containing the patch is not the source for what gets
merged?  This seems inefficient.

> > Please explain "pull request\( system\)?" more precisely.

> https://en.wikipedia.org/wiki/List_of_tools_for_code_review

> It keeps a list of all the pull requests coming in. They provide things
> like inline comments over diffs, threaded conversation, integration with
> continuous integration. Many of them, once the PR is complete, will
> automate the merge to master.


> Phil

Alan Mackenzie (Nuremberg, Germany).

reply via email to

[Prev in Thread] Current Thread [Next in Thread]