[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] fileio.c: introduce make_temp_name_buf

From: Alan Third
Subject: Re: [PATCH] fileio.c: introduce make_temp_name_buf
Date: Sun, 24 Jul 2016 21:01:02 +0100
User-agent: Mutt/1.5.24 (2015-08-30)

On Sun, Jul 24, 2016 at 08:28:19PM +0100, Alan Third wrote:
> I think it would make more sense to only check for base64_p when
> HAVE_LONG_FILE_NAMES is defined, though. If it’s not defined, it’s
> currently checking it then executing identical code whatever the
> outcome.
> Once that’s done we’re only duplicating the code once and I don’t
> know if it’s worth introducing a new function for that.

Actually, there’s no reasonable way to do rewrite this so it doesn’t
appear a total of three times, so the function is probably still
Alan Third

reply via email to

[Prev in Thread] Current Thread [Next in Thread]