[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Small fix in `shell--unquote&requote-argument' - please review

From: Stefan Monnier
Subject: Re: Small fix in `shell--unquote&requote-argument' - please review
Date: Wed, 31 Aug 2016 09:27:54 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux)

> 1. match is always less than (length str), so I guess they meant
> `((< (1+ match) (length qstr))'.
> 2. If `string-match' searching for ending single quote failed,
> `(match-string 0)' is still called - be careful not to do this.

Do you have corresponding recipes to trigger the corresponding errors
(so we could write tests)?  This part of my code is in dire need of
tests, otherwise it's much too easy to introduce regressions.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]