[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: 1) (elisp) `Advising Named Functions', 2) search filtering example
|
From: |
Noam Postavsky |
|
Subject: |
Re: 1) (elisp) `Advising Named Functions', 2) search filtering example |
|
Date: |
Mon, 17 Oct 2016 08:20:31 -0400 |
On Mon, Oct 17, 2016 at 1:25 AM, Drew Adams <address@hidden> wrote:
> 1. Node `Advising Named Functions' of the Elisp manual says this:
>
> For these reasons, advice should be reserved for the cases
> where you cannot modify a function’s behavior in any other way.
> If it is possible to do the same thing via a hook, that is
> preferable. ...
>
> In particular, Emacs’s own source files should not put advice
> on functions in Emacs. (There are currently a few exceptions
> to this convention, but we aim to correct them.)
>
> Is that still true? Is this the policy, even with the new
> advice system?
>
> If so, then it seems that it is being ignored, as new advice
> has been added to `isearch-filter-predicate' in `dired-aux.el'
> and `wdired.el'.
`advice-add' puts advice on a function, `add-function' does not.
`isearch-filter-predicate' is not a function, it's a variable
containing a function value.
- 1) (elisp) `Advising Named Functions', 2) search filtering example, Drew Adams, 2016/10/17
- Re: 1) (elisp) `Advising Named Functions', 2) search filtering example,
Noam Postavsky <=
- RE: 1) (elisp) `Advising Named Functions', 2) search filtering example, Drew Adams, 2016/10/17
- Re: 1) (elisp) `Advising Named Functions', 2) search filtering example, Noam Postavsky, 2016/10/17
- Re: 1) (elisp) `Advising Named Functions', 2) search filtering example, Stefan Monnier, 2016/10/17
- RE: 1) (elisp) `Advising Named Functions', 2) search filtering example, Drew Adams, 2016/10/17
- Re: 1) (elisp) `Advising Named Functions', 2) search filtering example, Stefan Monnier, 2016/10/17
- RE: 1) (elisp) `Advising Named Functions', 2) search filtering example, Drew Adams, 2016/10/17
- Re: 1) (elisp) `Advising Named Functions', 2) search filtering example, Stefan Monnier, 2016/10/17
- RE: 1) (elisp) `Advising Named Functions', 2) search filtering example, Drew Adams, 2016/10/17
- Re: 1) (elisp) `Advising Named Functions', 2) search filtering example, Noam Postavsky, 2016/10/17
- RE: 1) (elisp) `Advising Named Functions', 2) search filtering example, Drew Adams, 2016/10/17