[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] emacs-25 ee04aed: Fix handling of buffer relocation in

From: Stefan Monnier
Subject: Re: [Emacs-diffs] emacs-25 ee04aed: Fix handling of buffer relocation in regex.c functions
Date: Tue, 25 Oct 2016 08:20:25 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux)

>> How many of us know the constraints?  How many of those know them enough to
>> think about them when making changes?  How many of those get the answer
>> right when thinking about those problems?
> The same is true for many other parts of Emacs: bidi.c, syntax.c,
> composite.c, to name just a few.

I think it's worse because the answer to the question depends on
potentially the whole code (e.g. changing a piece of code such that it
now uses malloc means you have to check every caller (and caller's
caller, ...), and in other direction, when manipulating buffer text you
need to check every function you call (and the functions they call, ...)
to see if they may call malloc).

> Sure.  But we're already in the minefield, might as well be careful
> enough to not step on any mine, until we can get out.

I think we can get out right away.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]