[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 00/15] xwidget webkit improvements

From: Paul Eggert
Subject: Re: [PATCH v2 00/15] xwidget webkit improvements
Date: Tue, 25 Oct 2016 08:30:50 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0

Thanks. I tried that on Fedora 24 x86-64, and got the following diagnostic when using M-x xwidget-webkit-browse-url to visit http://cs.ucla.edu.

(emacs:22840): Gtk-WARNING **: Allocating size to GtkOffscreenWindow 0xd5b6d0 without calling gtk_widget_get_preferred_width/height(). How does the code know the size to allocate?

Is this something I should worry about?

A couple of minor things. First, in patch "Dynamically resize WebKit widget", this commit-message line exceeds 78 chars:

(xwidget-webkit-adjust-size-to-window): Make non-interactive, add widget and 
window as arguments.

so "git am" rejected it here. To help prevent this sort of problem in the future, run "./autogen.sh git". (72 chars or less is nice, so that ChangeLog lines fit in 80 columns.)

Second, in the patch "xwidget: Pass JavaScript return value to optional callback procedure" the new function webkit_js_to_lisp should be static. To catch this sort of thing in the future, use the --enable-gcc-warnings option to 'configure'.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]