[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] eww-open-in-new-buffer

From: Lars Ingebrigtsen
Subject: Re: [PATCH] eww-open-in-new-buffer
Date: Wed, 02 Nov 2016 20:22:47 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux)

Mark Oteiza <address@hidden> writes:

> I wanted something akin to "open in new tab" for eww, so I wrote the
> following.
> M-RET seemed a good binding.  One thing that bugs me about this is that
> eww-current-url in eww-suggest-uris didn't quite fit: as the new
> function is, it doesn't make sense if url is (eww-current-url).
> So, I made changes to eww-suggest-uris.  Alternatively,
> eww-open-in-new-buffer could check if url is equal to eww-current-url
> and just clone instead of invoking eww.  That might be better.

Looks good to me, I think.  It should probably have a NEWS entry and an
eww manual entry, though.

>  (defcustom eww-suggest-uris
>    '(eww-links-at-point
> -    url-get-url-at-point
> -    eww-current-url)
> +    url-get-url-at-point)

And this should have a :version "26.1".

(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

reply via email to

[Prev in Thread] Current Thread [Next in Thread]