[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Patches for Emacs 25.2

From: Dmitry Gutov
Subject: Re: Patches for Emacs 25.2
Date: Mon, 7 Nov 2016 12:39:06 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Thunderbird/50.0

On 07.11.2016 12:31, Michael Albinus wrote:

Can't we move the (file-remote-p ... 'localname) call to the first
hunk here? Then the patch will only change one place, and we get rid
of the added `or' here.

I let it to Nikolay.

Not sure I understand.

The patch for the emacs-25 branch is proposed by Nikolay.

Yes. And my comment applies to both it and your modified version.

However, given that this construct

  (or (file-remote-p FILE 'localname) FILE)

happens several times in the lisp sources, I wonder whether we shall
give it an own defmacro or defsubst (in master, of course).

I have no strong opinion either way, but your commit in master fixing
this problem does not have this construct.

Sure. It was a rather general comment, given that we find this construct
under .../emacs/lisp for at least 11 times, and under .../elpa 4 times.

I wouldn't mind such a function if we find a good name for it. No point in making it a macro or a defsubst, I think.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]