[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] master 3f06795: Migrate auth-source to cl-lib

From: Stefan Monnier
Subject: Re: [Emacs-diffs] master 3f06795: Migrate auth-source to cl-lib
Date: Sat, 12 Nov 2016 17:57:27 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux)

> @@ -712,7 +712,7 @@ must call it to obtain the actual value."
>                         (plist-get spec key)
>                         (slot-value backend key))
>                  (setq filtered-backends (delq backend filtered-backends))
> -                (return))
> +                (cl-return))
>              (invalid-slot-name nil))))

Hmm... This change looks right, but I believe there's a bug here:
with `cl`, `dolist` is advised to be CL's `dolist` which includes an
implicit (block nil ...) wrapper.  But with cl-lib, `dolist` is left alone
and you need to use `cl-dolist` to get that wrapper.

So I think you need to change the surrounding `dolist` to be `cl-dolist`
otherwise this `cl-return` will exit from the surrounding function
rather than from the inner loop.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]