[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] ash, lsh: Avoid code duplication

From: Davis Herring
Subject: Re: [PATCH] ash, lsh: Avoid code duplication
Date: Tue, 22 Nov 2016 09:48:20 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0

--- a/src/lisp.h
+++ b/src/lisp.h
@@ -602,6 +602,7 @@ extern void char_table_set (Lisp_Object, int, Lisp_Object);
 /* Defined in data.c.  */
 extern _Noreturn Lisp_Object wrong_type_argument (Lisp_Object, Lisp_Object);
 extern _Noreturn void wrong_choice (Lisp_Object, Lisp_Object);
+Lisp_Object ash_lsh_impl (Lisp_Object, Lisp_Object, bool);

No need to declare it here, as it is a static function used only in
the file in which it is defined.

In case it helps explain the issue, note that the "extern" here did nothing substantive: functions are extern if not static, and the extern keyword isn't needed to prevent a function declaration being a definition.


This product is sold by volume, not by mass. If it appears too dense or too sparse, it is because mass-energy conversion has occurred during shipping.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]