[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Lisp-friendly backtraces [was: Lispy backtraces]
From: |
Eli Zaretskii |
Subject: |
Re: Lisp-friendly backtraces [was: Lispy backtraces] |
Date: |
Tue, 06 Dec 2016 20:55:36 +0200 |
> Cc: address@hidden
> From: Clément Pit--Claudel <address@hidden>
> Date: Mon, 5 Dec 2016 13:59:03 -0500
>
> Done and done :) See attached patch.
Thanks.
> address@hidden mapbacktrace function &optional base
> +The function @code{mapbacktrace} calls @var{function} once for each
> +frame in the backtrace, starting at the first frame whose
> address@hidden is base (or from the top if @var{base} is omitted or
^^^^^^^^^^^^^^^^^^^^^^
Here, "function" should not have the @var markup, and "base" should.
> +the only supported property is @code{:debug-on-exit}, which is t if
^
@code{t}
> +the frame's debug-on-exit flag is set.
^^^^^^^^^^^^^
@code{debug-on-exit}
Also, suggest to say "stack frame's", to avoid confusion with the
frames on display.
> +(defun backtrace-frames (&optional base)
> + "Collect all frames of current backtrace into a list.
> +If non-nil BASE should be a function, and frames before its
^
Comma here.
> +(defun backtrace-frame (nframes &optional base)
> + "Return the function and arguments NFRAMES up from current execution point.
> +If non-nil BASE should be a function, and NFRAMES counts from its
^
Likewise.
> + if (backtrace_debug_on_exit (pdl))
> + flags = Fcons (QCdebug_on_exit, Fcons (Qt, Qnil));
^^^^
Too many blanks here. Should be only 2.
Otherwise, LGTM.
Thanks for doing this!
- Re: bug#24514: 24.5; Lispy backtraces, (continued)
- Re: bug#24514: 24.5; Lispy backtraces, Clément Pit--Claudel, 2016/12/04
- Re: bug#24514: 24.5; Lispy backtraces, Eli Zaretskii, 2016/12/04
- Lisp-friendly backtraces [was: Lispy backtraces], Clément Pit--Claudel, 2016/12/05
- Re: Lisp-friendly backtraces [was: Lispy backtraces], Stefan Monnier, 2016/12/05
- Re: Lisp-friendly backtraces [was: Lispy backtraces], Clément Pit--Claudel, 2016/12/05
- Re: Lisp-friendly backtraces [was: Lispy backtraces], Stefan Monnier, 2016/12/05
- Re: Lisp-friendly backtraces [was: Lispy backtraces], Clément Pit--Claudel, 2016/12/05
- Re: Lisp-friendly backtraces [was: Lispy backtraces], Eli Zaretskii, 2016/12/05
- Re: Lisp-friendly backtraces [was: Lispy backtraces], Eli Zaretskii, 2016/12/05
- Re: Lisp-friendly backtraces [was: Lispy backtraces], Clément Pit--Claudel, 2016/12/05
- Re: Lisp-friendly backtraces [was: Lispy backtraces],
Eli Zaretskii <=
- Re: Lisp-friendly backtraces [was: Lispy backtraces], Clément Pit--Claudel, 2016/12/07
- Re: Lisp-friendly backtraces [was: Lispy backtraces], Clément Pit--Claudel, 2016/12/12