emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [elpa] master 580a1b6: Respect .elpaignore when compiling and optimi


From: Stefan Monnier
Subject: Re: [elpa] master 580a1b6: Respect .elpaignore when compiling and optimize compilation.
Date: Mon, 26 Dec 2016 22:29:15 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux)

>> I haven't looked at the performance side of this.  It just seemed simpler.
> I say we keep it as-is, as my reading of the current commands is simpler
> than the way I read this alternative.  Compare the way I read it: "Make
> a tar archive and list its contents."  Versus: "Execute tar with verbose
> output, which happens to only include the files packaged, also that
> output needs to be redirected from stderr to stdout for make to process
> it, also bury the archive contents in /dev/null so as not to interfere
> with the redirected verbose output."

Fair enough.

> Also, I've attached a patch for the "pwd-based exclusions" issue I
> mentioned in my last email.  I checked the timing on it, and it only
> reduces the speed of "make" with nothing to do by about 50ms.  Does it
> look good to you?

Looks OK.  BTW, I saw that we could do

    included_els := $(shell tar -cvhf /dev/null --exclude-ignore=.elpaignore \
                                --exclude-vcs packages 2>&1 | grep '\.el$$')

except that --exclude-ignore is a fairly recent addition to GNU tar, so
it doesn't even work in Debian stable.


        Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]