[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Patches for Emacs 25.2

From: Nikolay Kudryavtsev
Subject: Re: Patches for Emacs 25.2
Date: Mon, 2 Jan 2017 21:43:39 +0300
User-agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0

Hello, Michael.

Just to be clear - we're talking about the current master. That one does not work. My original patch, or your rewrite in this thread works.

So here's what happens.

1. Msg-file has a local name as its value. Let's say I'm trying to commit into repository /pscp:server:/home/user/git-test/. Make-nearby-temp-file creates a file "/pscp:server:/home/user/git-test/git-msg23408zHn". Msg-file becomes "/home/user/git-test/git-msg23408zHn".

2. We concat a git command like "git commit /home/user/git-test/git-msg23408zHn". No problem here, since we need a local name.

3. (write-region (car args) nil msg-file) happens and it fails, because local name "/home/user/git-test/git-msg23408zHn" expands to "c:/home/user/git-test/git-msg23408Ncz" which is a file on a local machine and it does not exist.

The fix would be having absolute name for msg-file(/pscp:server:/home/user/git-test/git-msg23408zHn) and then using (or (file-remote-p msg-file 'localname) msg-file) for git commit. Everywhere else we need the absolute name.

I've attached those changes as patch.

Best Regards,
Nikolay Kudryavtsev

Attachment: remote-vc-git-master-fixed.patch
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]