[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] master 9ed3685a77: Lots of refactorings and a few mino

From: Paul Eggert
Subject: Re: [Emacs-diffs] master 9ed3685a77: Lots of refactorings and a few minor improvements.
Date: Wed, 4 Jan 2017 10:23:10 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1

Stefan Merten wrote:

I got the impression, that lately few people care about these rules

I'm afraid that impression is incorrect. Many developers care (hence this thread :-).

See for example:


Those examples merely rename locals or adjust comments, and typically this doesn't need to be mentioned in ChangeLogs. Your changes did more than that.

I hope the commit message below is what you require.

Much better, thanks. My main problem with it is that "Refactor by removing old functions, introducing new functions and change existing functions" is too vague. Please write for an audience that includes people who have code that calls (say) rst-comment-region and want to know how to adjust the code after your changes to the API.

At this point, by the way, the commit is done. We're talking about what you should do next time. (You can change the ChangeLog.3 file later if you like, but that's not urgent.)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]