[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Make purecopy create hash tables properly

From: Paul Eggert
Subject: Re: [PATCH] Make purecopy create hash tables properly
Date: Fri, 27 Jan 2017 14:06:46 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1

Thanks for the patch. It looks like the right thing to do. Could you please fix it up on the following minor ways?

* Use GNU style for C code: space between function and paren, braces nested GNU style, etc. Look in neighboring code for examples.

* Rewrite make_pure_hash_table so that it uses a loop rather than recursion, when it follows the next_weak link.

* Create a proper ChangeLog-style commit message.

* Send bug-gnu-emacs email containing the patch in 'git format-patch' format, e.g., by using the command 'git send-email'. Please see the "Commit messages" section in CONTRIBUTE for details about the commit message style.

Thanks again.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]