[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] checking eww download directory

From: Mark Oteiza
Subject: Re: [PATCH] checking eww download directory
Date: Sat, 28 Jan 2017 16:04:56 -0500
User-agent: Mutt/1.7.2+27 (e4ad1dc9bfbd) (2016-11-26)

On 28/01/17 at 03:14pm, Lars Ingebrigtsen wrote:
> Mark Oteiza <address@hidden> writes:
> > I just went off of knowing it's called Downloads in windows, and trying
> > to consider plural/nonplural and case insensitivity on Linux.  Mine, for
> > instance is just lower cased.  So... the cl-some is probably overkill.
> I think it's a good idea to try to find the "downloads" directory on the
> host system, but I think this should be factored out into its own
> function, so that we can use it in similar circumstances elsewhere.  

Fair, I'll leave it.

> Or perhaps there aren't any other directories like that?  Hm...  well,
> "documents", perhaps, and "desktop"...
> >> > +  (access-file eww-download-directory "Download failed")
> >> 
> >> Seem OK, except that the error message should say what the error is
> >> instead of this.
> >
> > It does, access-file appends the error:
> >
> >   Download failed: No such file or directory, ~/NOWOAIWJD
> Oh, cool.  Perhaps this line from the doc string could be clearer:

Yep, useful function.  I changed the docstring words to "prepended to"

reply via email to

[Prev in Thread] Current Thread [Next in Thread]