[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] feature/byte-switch 7c2d493: src/bytecode.c: Add optio

From: Vibhav Pant
Subject: Re: [Emacs-diffs] feature/byte-switch 7c2d493: src/bytecode.c: Add optional sanity check for jump tables.
Date: Sat, 11 Feb 2017 23:18:42 +0530

On Sat, Feb 11, 2017 at 9:21 PM, Stefan Monnier
<address@hidden> wrote:
>> +            /* Hash tables for switch are declared with :size set to the
>> +               exact number of cases.  */
>> +            if (BYTE_CODE_SAFE)
>> +              eassert (HASH_TABLE_SIZE (h) == h->count);
> Why should we force this constraint on the code that generates the
> hash-tables.  I think this is wrong.

Also, the rationale for putting a constraint on the :size of the hash
table was that it would save pure storage if the function (and thus
the jump table in the constant vector) was purecopied.

Vibhav Pant

reply via email to

[Prev in Thread] Current Thread [Next in Thread]