[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] master adfb6f1: Continue to fix bug#25607

From: Michael Albinus
Subject: Re: [Emacs-diffs] master adfb6f1: Continue to fix bug#25607
Date: Wed, 15 Feb 2017 22:41:39 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux)

Stefan Monnier <address@hidden> writes:

>>     * lisp/ido.el (ido-complete): Let-bind `non-essential' to nil.
> This looks wrong.  This in an interactive command executing an explicit
> request from the user, so it's definitely not non-essential.
> The compact on-the-fly display of the possible completions performed by
> IDO does qualify as `non-essential', but not ide-complete.

`non-essential' is bound exactly two times in ido.el now. In
`ido-read-internal' it is bound to t, preventing non-desired new
connections while the user is typing a file name in the minibuffer. And
in `ido-complete', called inside `ido-read-internal', it is bound to
nil, allowing new remote connections, since the user has triggered this
(by typing <TAB>.

I cannot see what's wrong with this.

>         Stefan

Best regards, Michael.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]