[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] master 9278d90: * lisp/emacs-lisp/pcase.el (pcase): Co
Re: [Emacs-diffs] master 9278d90: * lisp/emacs-lisp/pcase.el (pcase): Comment debug message (Bug#26177).
Sun, 26 Mar 2017 20:26:04 -0400
Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux)
> There is a testcase in the bugreport.
Looking at the problem again, I see that your patch is fine:
I didn't remember, but indeed I fixed the code to be "conservative" in
the sense that we detect when the memoization doesn't give a useful
answer and we just fall back to "no memoization", which should be good
enough in most cases anyway (nowadays memoization is almost only useful
for bootstrap anyway).
> On 26 March 2017 at 16:17, Stefan Monnier <address@hidden> wrote:
>>> - (when data
>>> - (message "pcase-memoize: equal first branch, yet different"))
>>> + ;; (when data
>>> + ;; (message "pcase-memoize: equal first branch, yet different"))
>> I'm curious: where did you bump into it?
>> [ The reason I'm curious, is that it's basically detecting a bug in
>> pcase's memoization, so if you saw that message, we need to improve
>> it. ]