[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master ef44346 2/2: Make it easier to abort a series of tests with C
From: |
Lars Brinkhoff |
Subject: |
Re: master ef44346 2/2: Make it easier to abort a series of tests with C-g |
Date: |
Tue, 28 Mar 2017 11:29:06 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Noam Postavsky wrote:
> Make it easier to abort a series of tests with C-g
>
> * emacs-lisp/ert.el (ert-run-tests): Add "interactively" arg. If
> interactively is true and a test was aborted then ask if the remaining
> tests should be aborted too.
> (ert-run-tests-batch, ert-run-tests-interactively): Pass in
> interactively arg.
This commit adds a testsuite failure when I run:
git clean -xfd && ./autogen.sh && make bootstrap && make check
If I revert this commit, the failure goes away. It seems there's a call
to ert-run-tests that hasn't been updated with a third argument.
>From test/lisp/emacs-lisp/ert-x-tests.el:
Test ert-test-test-buffers backtrace:
(let ((test-1 (progn "Constructor for objects of type `ert-test'." (
(let (buffer-1 buffer-2) (let ((test-1 (progn "Constructor for objec
(lambda nil (let (buffer-1 buffer-2) (let ((test-1 (progn "Construct
ert--run-test-internal([cl-struct-ert--test-execution-info [cl-struc
ert-run-test([cl-struct-ert-test ert-test-test-buffers nil (lambda n
ert-run-or-rerun-test([cl-struct-ert--stats (not (tag :expensive-tes
ert-run-tests((not (tag :expensive-test)) #[385 "\306\307\"address@hidden
ert-run-tests-batch((not (tag :expensive-test)))
ert-run-tests-batch-and-exit((not (tag :expensive-test)))
eval((ert-run-tests-batch-and-exit (quote (not (tag :expensive-test)
command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/emacs-lisp/ert-x-tes
command-line()
normal-top-level()
Test ert-test-test-buffers condition:
(wrong-number-of-arguments
(3 . 3)
2)
FAILED 9/9 ert-test-test-buffers
- Re: master ef44346 2/2: Make it easier to abort a series of tests with C-g,
Lars Brinkhoff <=