[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] master 716b468: Extend `file-notify-test02-rm-watch'

From: Andreas Politz
Subject: Re: [Emacs-diffs] master 716b468: Extend `file-notify-test02-rm-watch'
Date: Wed, 05 Apr 2017 23:02:33 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux)

Ken Brown <address@hidden> writes:

> This may be another of those timing issues that we've dealt with
> before [...].

I think it is as well.  If cygwin's file-notify back-end runs on a polling
timer, we need to make sure that it has acknowledged the file's
existence before we delete it.  Maybe you could try out the following

diff --git a/test/lisp/filenotify-tests.el b/test/lisp/filenotify-tests.el
index 54e7ebfc0e..9b5c751021 100644
--- a/test/lisp/filenotify-tests.el
+++ b/test/lisp/filenotify-tests.el
@@ -425,6 +425,7 @@ file-notify--test-make-temp-name
                   '(change) #'second-callback)))
           ;; Remove first watch.
           (file-notify-rm-watch file-notify--test-desc)
+          (file-notify--test-read-event)
           ;; Only the second callback shall run.
           (delete-file file-notify--test-tmpfile)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]